From 315a356fdafa516168256e5af7de5c8a81a36d6e Mon Sep 17 00:00:00 2001 From: Vadim Stepanov Date: Mon, 5 Sep 2022 15:59:05 +0100 Subject: [PATCH] Handle vendor = None for pagerduty migrator (#483) --- .../migrator/resources/integrations.py | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tools/pagerduty-migrator/migrator/resources/integrations.py b/tools/pagerduty-migrator/migrator/resources/integrations.py index ee06bb3a..5d8a0932 100644 --- a/tools/pagerduty-migrator/migrator/resources/integrations.py +++ b/tools/pagerduty-migrator/migrator/resources/integrations.py @@ -17,10 +17,14 @@ def match_integration(integration: dict, oncall_integrations: list[dict]) -> Non def match_integration_type(integration: dict, vendors: list[dict]) -> None: vendors_map = {vendor["id"]: vendor for vendor in vendors} - if integration["type"] not in [ - "generic_events_api_inbound_integration", - "events_api_v2_inbound_integration", - ]: + if ( + integration["type"] + not in [ + "generic_events_api_inbound_integration", + "events_api_v2_inbound_integration", + ] + or integration["vendor"] is None + ): integration["oncall_type"] = None return @@ -57,7 +61,9 @@ def create_integration( integration = oncall_api_client.create("integrations", payload) - routes = oncall_api_client.list_all("routes/?integration_id={}".format(integration["id"])) + routes = oncall_api_client.list_all( + "routes/?integration_id={}".format(integration["id"]) + ) default_route_id = routes[0]["id"] oncall_api_client.update(