fix broker.type in helm values

helm/oncall/templates/_env.tpl

@@ -528,10 +528,15 @@
       key: {{ include "snippet.redis.password.secret.key" . | quote}}
 {{- end }}
 
+{{- /*
+when broker.type != rabbitmq, we do not need to include rabbitmq environment variables
+*/}}
 {{- define "snippet.broker.env" -}}
 {{- include "snippet.redis.env" . }}
+{{- if eq .Values.broker.type "rabbitmq" -}}
 {{- include "snippet.rabbitmq.env" . }}
 {{- end }}
+{{- end }}
 
 {{- define "snippet.db.env" -}}
 {{- if eq .Values.database.type "mysql" }}

helm/oncall/tests/redis_env_test.yaml

@@ -109,6 +109,7 @@ tests:
       - celery/deployment.yaml
     set:
       broker.type: redis
+      rabbitmq.enabled: false
       redis.enabled: false
       externalRedis:
         host: custom-host