From 017b22b905c9014a9d1bd75e9825f1e57c2f0dc1 Mon Sep 17 00:00:00 2001 From: Vadim Stepanov Date: Wed, 6 Sep 2023 15:23:53 +0100 Subject: [PATCH] Enable email notification step by default on Helm (#2975) # What this PR does Set `oncall.smtp.enabled` to `true` by default to enable email notifications on Helm deployments. Email notifications are enabled by default on docker-compose deployments already: see [this feature flag](https://github.com/grafana/oncall/blob/df6f6183ecc9e541d07317590db9d3affb7097ab/engine/settings/base.py#L63). ## Which issue(s) this PR fixes https://github.com/grafana/oncall/issues/2917 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --- CHANGELOG.md | 1 + helm/oncall/values.yaml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bb99cd31..d43f36ad 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed +- Enable email notification step by default on Helm by @vadimkerr ([#2975](https://github.com/grafana/oncall/pull/2975)) - Handle slack resolution note errors consistently ([#2976](https://github.com/grafana/oncall/pull/2976)) ## v1.3.35 (2023-09-05) diff --git a/helm/oncall/values.yaml b/helm/oncall/values.yaml index 73f07b4d..cbb326a9 100644 --- a/helm/oncall/values.yaml +++ b/helm/oncall/values.yaml @@ -198,7 +198,7 @@ oncall: # The key in the secret containing Telegram token tokenKey: "" smtp: - enabled: false + enabled: true host: ~ port: ~ username: ~