oncall-engine/engine/apps/telegram/models/connectors/channel.py

141 lines
5.2 KiB
Python
Raw Normal View History

import logging
import typing
from django.conf import settings
from django.core.validators import MinLengthValidator
from django.db import models
from django.db.models import Q
from telegram import error
from apps.alerts.models import AlertGroup
from apps.telegram.client import TelegramClient
from apps.telegram.models import TelegramMessage
from common.insight_log.chatops_insight_logs import ChatOpsEvent, ChatOpsTypePlug, write_chatops_insight_log
from common.public_primary_keys import generate_public_primary_key, increase_public_primary_key_length
if typing.TYPE_CHECKING:
from django.db.models.manager import RelatedManager
from apps.alerts.models import ChannelFilter
logger = logging.getLogger(__name__)
def generate_public_primary_key_for_telegram_to_at_connector() -> str:
prefix = "Z"
new_public_primary_key = generate_public_primary_key(prefix)
failure_counter = 0
while TelegramToOrganizationConnector.objects.filter(public_primary_key=new_public_primary_key).exists():
new_public_primary_key = increase_public_primary_key_length(
failure_counter=failure_counter, prefix=prefix, model_name="TelegramToOrganizationConnector"
)
failure_counter += 1
return new_public_primary_key
class TelegramToOrganizationConnector(models.Model):
channel_filter: "RelatedManager['ChannelFilter']"
public_primary_key = models.CharField(
max_length=20,
validators=[MinLengthValidator(settings.PUBLIC_PRIMARY_KEY_MIN_LENGTH + 1)],
unique=True,
default=generate_public_primary_key_for_telegram_to_at_connector,
)
organization = models.ForeignKey(
"user_management.Organization",
on_delete=models.CASCADE,
related_name="telegram_channel",
)
is_default_channel = models.BooleanField(null=True, default=False)
channel_chat_id = models.CharField(unique=True, max_length=100)
channel_name = models.CharField(max_length=100, null=True, default=None)
discussion_group_chat_id = models.CharField(unique=True, max_length=100)
discussion_group_name = models.CharField(max_length=100, null=True, default=None)
datetime = models.DateTimeField(auto_now_add=True)
NUM_GROUPED_ALERTS_IN_COMMENTS = 10
@property
def is_configured(self) -> bool:
return self.channel_chat_id is not None and self.discussion_group_chat_id is not None
@classmethod
def get_channel_for_alert_group(cls, alert_group: AlertGroup) -> typing.Optional["TelegramToOrganizationConnector"]:
# TODO: add custom queryset
dm_messages_exist = alert_group.telegram_messages.filter(
~Q(chat_id__startswith="-")
& Q(
message_type__in=(
TelegramMessage.PERSONAL_MESSAGE,
TelegramMessage.FORMATTING_ERROR,
)
),
).exists()
if dm_messages_exist:
return None
default_channel = cls.objects.filter(
organization=alert_group.channel.organization, is_default_channel=True
).first()
if alert_group.channel_filter is None:
return default_channel
if not alert_group.channel_filter.notify_in_telegram:
return None
return alert_group.channel_filter.telegram_channel or default_channel
def make_channel_default(self, author):
try:
old_default_channel = TelegramToOrganizationConnector.objects.get(
organization=self.organization, is_default_channel=True
)
old_default_channel.is_default_channel = False
old_default_channel.save(update_fields=["is_default_channel"])
except TelegramToOrganizationConnector.DoesNotExist:
old_default_channel = None
self.is_default_channel = True
self.save(update_fields=["is_default_channel"])
write_chatops_insight_log(
author=author,
event_name=ChatOpsEvent.DEFAULT_CHANNEL_CHANGED,
chatops_type=ChatOpsTypePlug.TELEGRAM.value,
prev_channel=old_default_channel.channel_name if old_default_channel else None,
new_channel=self.channel_name,
)
def send_alert_group_message(self, alert_group: AlertGroup) -> None:
telegram_client = TelegramClient()
try:
telegram_client.send_message(
chat_id=self.channel_chat_id, message_type=TelegramMessage.ALERT_GROUP_MESSAGE, alert_group=alert_group
)
except error.BadRequest as e:
fix `apps.telegram.tasks.send_log_and_actions_message` retrying tasks (#4851) # What this PR does It _appears_ like Telegram may have changed one of the error messages they return for `telegram.error.BadRequest`. This _may_ be causing us to infinitely retry some of these tasks. Previously we were checking for two variants of the same type of error message: - "Message to reply not found" - "Replied message not found" _However_, if I search for the following [in the logs](https://ops.grafana-ops.net/goto/hMgBb8CSR?orgId=1): ```logql {namespace="amixr-prod"} |~ `(Message to be replied not found|Message to reply not found|Replied message not found)` ```` I _only_ see references to "Message to be replied not found". I have updated references to the former to this new error log message we are seeing. Also: - deduplicate some of the words we check for in `telegram.error.BadRequest` and `telegram.error.Unauthorized` into `apps.telegram.client.TelegramClient.BadRequestMessage` and `apps.telegram.client.TelegramClient.UnauthorizedMessage` respectively - deduplicate some of the wording we use in the `reason` arg passed to `TelegramToUserConnector.create_telegram_notification_error` into `apps.telegram.models.connectors.personal.TelegramToUserConnector.NotificationErrorReason` - standardize how we check the `message` attribute of `telegram.error.TelegramError`s into a new `error_message_is` static method on `apps.telegram.client.TelegramClient` - previously we would check these error messages in two different ways: ```python3 # style 1 if "error message to check" in e.message: # do something # style 2 if error.message == "error message to check": # do something ``` ## Which issue(s) this PR closes Closes https://github.com/grafana/oncall-private/issues/2868 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes.
2024-08-19 14:05:40 -04:00
if TelegramClient.error_message_is(
e,
[
TelegramClient.BadRequestMessage.NEED_ADMIN_RIGHTS_IN_THE_CHANNEL,
TelegramClient.BadRequestMessage.CHAT_NOT_FOUND,
],
):
logger.warning(
f"Could not send alert group to Telegram channel with id {self.channel_chat_id} "
fix `apps.telegram.tasks.send_log_and_actions_message` retrying tasks (#4851) # What this PR does It _appears_ like Telegram may have changed one of the error messages they return for `telegram.error.BadRequest`. This _may_ be causing us to infinitely retry some of these tasks. Previously we were checking for two variants of the same type of error message: - "Message to reply not found" - "Replied message not found" _However_, if I search for the following [in the logs](https://ops.grafana-ops.net/goto/hMgBb8CSR?orgId=1): ```logql {namespace="amixr-prod"} |~ `(Message to be replied not found|Message to reply not found|Replied message not found)` ```` I _only_ see references to "Message to be replied not found". I have updated references to the former to this new error log message we are seeing. Also: - deduplicate some of the words we check for in `telegram.error.BadRequest` and `telegram.error.Unauthorized` into `apps.telegram.client.TelegramClient.BadRequestMessage` and `apps.telegram.client.TelegramClient.UnauthorizedMessage` respectively - deduplicate some of the wording we use in the `reason` arg passed to `TelegramToUserConnector.create_telegram_notification_error` into `apps.telegram.models.connectors.personal.TelegramToUserConnector.NotificationErrorReason` - standardize how we check the `message` attribute of `telegram.error.TelegramError`s into a new `error_message_is` static method on `apps.telegram.client.TelegramClient` - previously we would check these error messages in two different ways: ```python3 # style 1 if "error message to check" in e.message: # do something # style 2 if error.message == "error message to check": # do something ``` ## Which issue(s) this PR closes Closes https://github.com/grafana/oncall-private/issues/2868 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes.
2024-08-19 14:05:40 -04:00
f"due to {e.message}. alert_group {alert_group.pk}"
)
else:
telegram_client.send_message(
chat_id=self.channel_chat_id, message_type=TelegramMessage.FORMATTING_ERROR, alert_group=alert_group
)